AO3-6773 Fix url param pluralisation in invite_request_declined mailer preview #4976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Scope: Tests Only
brianjaustin
added
the
Priority: High - Broken on Test
brianjaustin
reviewed
Dec 2, 2024
amecreate
force-pushed
the
AO3-6773_invite_request_declined_mailer_preview_bugfix
branch
from
e074aac to
56e9dae
Compare
brianjaustin
approved these changes
Dec 2, 2024
amecreate
deleted the
AO3-6773_invite_request_declined_mailer_preview_bugfix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-6773
Purpose
Convert URL parameters to a number (
to_i) before passing them to the mailer preview.Testing Instructions
See Jira
References
See discussion in the same ticket on Jira.
config/locales/phrase-exports/ru.ymlis missing theotherpluralisation rule in multiple places. When a locale tries to use pluralisation, it errors.Credit
Amy Lee